RFR: 8295804: javax/swing/JFileChooser/JFileChooserSetLocationTest.java failed with "setLocation() is not working properly" [v2]

Sergey Bylokhov serb at openjdk.org
Fri Jan 12 01:22:24 UTC 2024


On Thu, 11 Jan 2024 06:46:43 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review fix
>
> test/jdk/javax/swing/JFileChooser/JFileChooserSetLocationTest.java line 217:
> 
>> 215:         int screenWidth = (int) screenSize.getWidth() / 2;
>> 216:         int screenHeight = (int) screenSize.getHeight() / 2;
>> 217:         frame = new JFrame();
> 
> Frame should have title.

"screenWidth" and "screenHeight" seems not the width and height, it is better to use some other name.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17364#discussion_r1449629687


More information about the client-libs-dev mailing list