RFR: 8316931: [macos14] Test "java/awt/TrayIcon/ShowAfterDisposeTest/ShowAfterDisposeTest.html" throws and exception on Mac OS 14(x64, aarch64) [v2]
Abhishek Kumar
abhiscxk at openjdk.org
Fri Jan 12 04:16:19 UTC 2024
On Wed, 10 Jan 2024 21:08:35 GMT, Alisen Chung <achung at openjdk.org> wrote:
>> SunToolkit.java is trying to post an event on the TrayIcon appContext, but the TrayIcon was already removed by the test, causing an error. The fix is to make SunToolkit skip posting the event if appContext is null. The test is also updated to remove applet usage and use PassFailJFrame instead.
>
> Alisen Chung has updated the pull request incrementally with two additional commits since the last revision:
>
> - spacing
> - updated test title, copyright year, removed redundant check
Extra blank lines can be removed else looks good to me.
Since `html` file has been removed, I guess the java file can be taken out of `ShowAfterDisposeTest` folder.
-------------
Marked as reviewed by abhiscxk (Committer).
PR Review: https://git.openjdk.org/jdk/pull/17329#pullrequestreview-1817331918
PR Comment: https://git.openjdk.org/jdk/pull/17329#issuecomment-1888406196
More information about the client-libs-dev
mailing list