RFR: 8320328: Restore interrupted flag in ImageIcon.loadImage
Alexey Ivanov
aivanov at openjdk.org
Fri Jan 12 19:47:18 UTC 2024
On Fri, 12 Jan 2024 19:17:24 GMT, Rajat Mahajan <rmahajan at openjdk.org> wrote:
> ImageIcon.loadImage used to handle InterruptedException only by printing a message to the console. JDK-8236987 handled the interrupted state more gracefully, but it didn't restore the interrupted flag.
> This change restores the interrupted flag that will allow the following code to handle interruption and exit the thread; otherwise, the thread will continue to run.
Looks good to me.
Could you update the [`LoadInterruptTest.java`](https://github.com/openjdk/jdk/blob/f26403172f2e19e2ed4efd0f06f00beaebde1031/test/jdk/javax/swing/ImageIcon/LoadInterruptTest.java) test to verify that the thread remains interrupted?
-------------
Changes requested by aivanov (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/17406#pullrequestreview-1818937822
More information about the client-libs-dev
mailing list