RFR: 4760025: sRGB conversions to and from CIE XYZ incorrect [v2]

Alexey Ivanov aivanov at openjdk.org
Fri Jan 12 21:41:24 UTC 2024


On Fri, 12 Jan 2024 20:51:38 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> Since the time the bug was reported color conversion accuracy for the sRGB profile and specific values from the report increased by x100. This is a request to add the code from the report as a test case.
>
> Sergey Bylokhov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update SimpleSRGBToFromCIEXYZ.java

Marked as reviewed by aivanov (Reviewer).

test/jdk/java/awt/color/ICC_ColorSpace/SimpleSRGBToFromCIEXYZ.java line 42:

> 40: 
> 41:             if (inv[0] != 0 || Math.abs(inv[1] - g) > 0.0001f || inv[2] != 0) {
> 42:                 System.err.println("Expected color:\t" + toString(rgb));

`Arrays.toString(rgb)` instead of custom `toString`?

-------------

PR Review: https://git.openjdk.org/jdk/pull/17388#pullrequestreview-1819090964
PR Review Comment: https://git.openjdk.org/jdk/pull/17388#discussion_r1450946738


More information about the client-libs-dev mailing list