RFR: 8316497 : ColorConvertOp - typo for non-ICC conversions needs one-line fix [v14]

Alexey Ivanov aivanov at openjdk.org
Sun Jan 14 20:34:23 UTC 2024


On Sun, 14 Jan 2024 09:31:29 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

> > Currently, we have test and gold which use the same ColorSpace which could be plain or wrapper for both cases. It looks confusing to me.
> 
> That could be fine. We can create a gold image first, then parametrize the test method by different src/mid/dst and compare the result vs gold, so we will cover all possible combinations.

It tried it… with for-loop over `ColorSpaceSelector.PYCC` and `ColorSpaceSelector.WRAPPED_PYCC` and I didn't like the result. Although I kept all the images inside the loop to be safe.

The approach above repeats several lines, however, it's more straightforward and reporting errors is easier: you'll the the line where exception occurred. If it's in the loop, the exception could happen on the same line but with different parameters.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16895#discussion_r1451798570


More information about the client-libs-dev mailing list