RFR: 8317287: [macos14] InterJVMGetDropSuccessTest.java: Child VM: abnormal termination [v11]

Alexey Ivanov aivanov at openjdk.org
Tue Jan 16 17:51:27 UTC 2024


On Tue, 16 Jan 2024 17:29:50 GMT, songpv-imt <duke at openjdk.org> wrote:

>> The root cause of the bug is because mousePress() method is invoked before mouseMove() event is completely processed causing the drag & drop behavior not being able to be recognized properly. This in turn makes the method dragSourceListener.isDropFinished() returns false and fail the test. To fix this, setAutoWaitForIdle(true) and Thread.Sleep is called to make sure the mouseMove() event is processed completely before moving to execute the mousePress() method.
>> 
>> JBS issue: [JDK-8317287](https://bugs.openjdk.org/browse/JDK-8317287)
>
> songpv-imt has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update InterJVMGetDropSuccessTest.java

Marked as reviewed by aivanov (Reviewer).

test/jdk/java/awt/dnd/InterJVMGetDropSuccessTest/InterJVMGetDropSuccessTest.java line 143:

> 141:     static final Object SYNC_LOCK = new Object();
> 142:     static final int MOUSE_RELEASE_TIMEOUT = 1000;
> 143: 

I'd rather preserve these blank lines because they separate blocks of fields: exit codes, timeout, sync object.

-------------

PR Review: https://git.openjdk.org/jdk/pull/16396#pullrequestreview-1824415165
PR Review Comment: https://git.openjdk.org/jdk/pull/16396#discussion_r1453768811


More information about the client-libs-dev mailing list