RFR: 8317287: [macos14] InterJVMGetDropSuccessTest.java: Child VM: abnormal termination [v13]

Alexey Ivanov aivanov at openjdk.org
Tue Jan 16 20:39:55 UTC 2024


On Tue, 16 Jan 2024 18:54:42 GMT, songpv-imt <duke at openjdk.org> wrote:

>> The root cause of the bug is because mousePress() method is invoked before mouseMove() event is completely processed causing the drag & drop behavior not being able to be recognized properly. This in turn makes the method dragSourceListener.isDropFinished() returns false and fail the test. To fix this, setAutoWaitForIdle(true) and Thread.Sleep is called to make sure the mouseMove() event is processed completely before moving to execute the mousePress() method.
>> 
>> JBS issue: [JDK-8317287](https://bugs.openjdk.org/browse/JDK-8317287)
>
> songpv-imt has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update InterJVMGetDropSuccessTest.java
>   - Fix whitespace errors

test/jdk/java/awt/dnd/InterJVMGetDropSuccessTest/InterJVMGetDropSuccessTest.java line 164:

> 162: 
> 163:     static final Object SYNC_LOCK = new Object();
> 164:     static final Util theInstance = new Util();

Could you please add the blank lines as they were so that this piece of code looks like this:


    public static final int CODE_FIRST_SUCCESS = 0x2;
    public static final int CODE_SECOND_SUCCESS = 0x2;
    public static final int CODE_FAILURE = 0x1;

    public static final int FRAME_ACTIVATION_TIMEOUT = 1000;

    static final Object SYNC_LOCK = new Object();

    static final Util theInstance = new Util();


With blank lines separating logical blocks of fields.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16396#discussion_r1454000543


More information about the client-libs-dev mailing list