RFR: 8316497 : ColorConvertOp - typo for non-ICC conversions needs one-line fix

Alexey Ivanov aivanov at openjdk.org
Thu Jan 18 10:10:30 UTC 2024


On Fri, 12 Jan 2024 02:55:59 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> @mrserb ,
>> 
>> Did you mean to use the wrapper for the middle like `ColorSpace mid = createCS(ColorSpaceSelector.WRAPPED_PYCC);` , So we can achieve : 
>> 
>>   **From**
>>  wrapper->icc_color_space->wrapper 
>>  icc_color_space->icc_color_space->icc_color_space
>> 
>>    **To** :
>>  wrapper->wrapper->wrapper 
>>  icc_color_space->wrapper->icc_color_space
>> 
>> Correct me if I am wrong
>
>>Did you mean to use the wrapper for the middle like ColorSpace mid = createCS(ColorSpaceSelector.WRAPPED_PYCC); , So we can achieve :
> 
> Just repeat existed checks using wrapper. So you will have all combinations:
> 
>> wrapper->icc_color_space->wrapper
>> icc_color_space->icc_color_space->icc_color_space
>> wrapper->wrapper->wrapper
>> icc_color_space->wrapper->icc_color_space

Thank you, @mrserb, for the valuable review, the fix and the test have become more comprehensive as the result. Greatly appreciated!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16895#issuecomment-1898170895


More information about the client-libs-dev mailing list