RFR: JDK-8323695 RenderPerf (2D) enhancements (23.12)
Phil Race
prr at openjdk.org
Thu Jan 18 21:38:24 UTC 2024
On Thu, 18 Jan 2024 08:59:07 GMT, Laurent Bourgès <lbourges at openjdk.org> wrote:
>> test/jdk/performance/client/RenderPerfTest/src/renderperf/RenderPerfTest.java line 460:
>>
>>> 458: if (id % 100 != 0) return;
>>> 459: if (font == null) {
>>> 460: font = new Font("LucidaGrande", Font.PLAIN, 32);
>>
>> I see this is pre-existing, but we should change this.
>> That's a font available only on macOS. You should either look up a font to use on the system at run time,
>> or use a logical font.
>
> Of course, I will make constant Font instances (no new Font() in benchmark code!) and use family name (Dialog or SansSerif), what do you prefer?
either dialog or sansserif. Dialog is the default font so perhaps that.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17408#discussion_r1458001361
More information about the client-libs-dev
mailing list