RFR: 8320692: Null icon returned for .exe without custom icon [v2]
Alexander Zuev
kizune at openjdk.org
Mon Jan 22 21:07:04 UTC 2024
On Mon, 22 Jan 2024 16:22:31 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> test/jdk/javax/swing/JFileChooser/FileSystemView/NoIconExeNPE.java line 264:
>>
>>> 262: FileSystemView fsv = FileSystemView.getFileSystemView();
>>> 263: // No NullPointerException is expected
>>> 264: fsv.getSystemIcon(hello.toFile());
>>
>> Maybe we should check that something useful is returned? at least non-null VS null value?
>
>> Maybe we should check that something useful is returned? at least non-null VS null value?
>
> Makes sense to ensure the returned value is not `null`.
Sure.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17475#discussion_r1462417222
More information about the client-libs-dev
mailing list