RFR: 6510914: JScrollBar.getMinimumSize() breaks the contract of JComponent.setMinimumSize() [v10]
Prasanta Sadhukhan
psadhukhan at openjdk.org
Tue Jan 23 03:32:47 UTC 2024
> javadoc contract for JComponent.setMinimumSize(Dimension) states:
>
> "Sets the minimum size of this component to a constant value. Subsequent calls to getMinimumSize will always return this value..."
>
> However, JScrollBar overrides getMinimumSize() and breaks this contract - it always returns a minimum size derived from the preferred size even if you have previously called setMinimumSize()
>
> Fix is made to check if mnimumSize is set and if so, honour it..
Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
PR update as per review
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/15325/files
- new: https://git.openjdk.org/jdk/pull/15325/files/1a7bc6e8..c6511063
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=15325&range=09
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=15325&range=08-09
Stats: 24 lines in 1 file changed: 6 ins; 12 del; 6 mod
Patch: https://git.openjdk.org/jdk/pull/15325.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/15325/head:pull/15325
PR: https://git.openjdk.org/jdk/pull/15325
More information about the client-libs-dev
mailing list