RFR: 8324243: Fix GCC 14 build

[Phil Race]

On Tue, 23 Jan 2024 19:17:06 GMT, Sam James <duke at openjdk.org> wrote:

>> src/java.desktop/share/native/libharfbuzz/hb-object.hh line 328:
>> 
>>> 326:   if (unlikely (!user_data))
>>> 327:   {
>>> 328:     user_data = (hb_user_data_array_t *) hb_calloc (sizeof (hb_user_data_array_t), 1);
>> 
>> Note 
>> (1) We don't cherry pick unless it is critical.
>> (2) I doubt you have ownership of harfbuzz code such that you can contribute any part of it to JDK in accordance with the OCA you signed.
>> 
>> Accordingly, the right thing to do here is disable the warning for this library and tool chain.
>
> Sure, I wasn't exactly hiding that it was cherry-picked. I did not consider (2) to be an issue given OpenJDK wholesale imports releases, but w/e. (The fix is also trivial and essentially the only possible fix...)
> 
> Anyway, happy to do that. Can you suggest what the idiomatic way of doing that in the OpenJDK codebase is for imported libs?

add the warning here 
https://github.com/openjdk/jdk/blob/8b9bf758801400e4491326cd4c90fc117b9d97e1/make/modules/java.desktop/lib/Awt2dLibraries.gmk#L506

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17506#discussion_r1463888153