RFR: 8316931: [macos14] Test "java/awt/TrayIcon/ShowAfterDisposeTest/ShowAfterDisposeTest.html" throws and exception on Mac OS 14(x64, aarch64) [v7]

Alisen Chung achung at openjdk.org
Sat Jan 27 05:44:49 UTC 2024


> SunToolkit.java is trying to post an event on the TrayIcon appContext, but the TrayIcon was already removed by the test, causing an error. The fix is to make SunToolkit skip posting the event if appContext is null. The test is also updated to remove applet usage and use PassFailJFrame instead.

Alisen Chung has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the last revision:

 - remove null check in SunToolkit, remove setting target to null in CTrayIcon
 - Merge branch 'master' of https://github.com/openjdk/jdk into 8316931
 - added suggested changes, moved test back into folder
 - added suggested changes, moved test back into folder
 - used jtreg.SkippedException, updated copyright years
 - removed extra newlines, moved test out of folder
 - spacing
 - updated test title, copyright year, removed redundant check
 - removed applet usage in test, fixed event posted on wrong app context bug

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17329/files
  - new: https://git.openjdk.org/jdk/pull/17329/files/a9693565..fed411c1

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17329&range=06
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17329&range=05-06

  Stats: 33627 lines in 1063 files changed: 19094 ins; 10650 del; 3883 mod
  Patch: https://git.openjdk.org/jdk/pull/17329.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17329/head:pull/17329

PR: https://git.openjdk.org/jdk/pull/17329


More information about the client-libs-dev mailing list