RFR: 8324681: Replace NULL with nullptr in HotSpot jtreg test native code files [v3]

Kevin Walls kevinw at openjdk.org
Sat Jan 27 11:57:35 UTC 2024


On Fri, 26 Jan 2024 21:06:00 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> This mechanically replaces NULL with nullptr in hpp/cpp native files in test native code.  This didn't attempt to change NULL in comments to say null because nullptr is generally the right thing for the comment to say.  It does attempt to change NULL to "null" rather than "nullptr" in strings.  Any changes for "nullptr" to "null" in comments can be changed in a future RFE in a smaller patch. I didn't see any when it was scrolling by to make my script more complicated.
>> 
>> Ran tier1-4 testing.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix nullptr only contained in strings.

test/hotspot/jtreg/serviceability/jvmti/vthread/VThreadTest/libVThreadTest.cpp line 426:

> 424:   }
> 425: 
> 426:   // #5: Test JVMTI GetLocalObject function with nullptr value_ptr

"with null value_ptr" ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17593#discussion_r1468449036


More information about the client-libs-dev mailing list