RFR: 8324681: Replace NULL with nullptr in HotSpot jtreg test native code files [v4]

Kim Barrett kbarrett at openjdk.org
Sun Jan 28 20:28:26 UTC 2024


On Sat, 27 Jan 2024 18:24:45 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> This mechanically replaces NULL with nullptr in hpp/cpp native files in test native code.  This didn't attempt to change NULL in comments to say null because nullptr is generally the right thing for the comment to say.  It does attempt to change NULL to "null" rather than "nullptr" in strings.  Any changes for "nullptr" to "null" in comments can be changed in a future RFE in a smaller patch. I didn't see any when it was scrolling by to make my script more complicated.
>> 
>> Ran tier1-4 testing.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix one nullptr in comments as found by @kevinw

Looks good.

-------------

Marked as reviewed by kbarrett (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17593#pullrequestreview-1847625136


More information about the client-libs-dev mailing list