RFR: 6510914: JScrollBar.getMinimumSize() breaks the contract of JComponent.setMinimumSize() [v12]
Prasanta Sadhukhan
psadhukhan at openjdk.org
Mon Jan 29 10:20:53 UTC 2024
On Mon, 29 Jan 2024 10:07:35 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>>
>> javadoc update in JScrollbar and JComponent
>
> src/java.desktop/share/classes/javax/swing/JScrollBar.java line 785:
>
>> 783: * Returns the minimum size for the {@code JScrollBar}.
>> 784: * The scrollbar is flexible along its scrolling axis and
>> 785: * rigid along the other axis.
>
> I would rather clarify this property by describing how the returned value is derived from the preferred size. Does it make sense? Should it be an `@implNote` rather than a spec? Or is it completely unnecessary?
Not sure..Since it is already reviewed and approved by Phil, I chose to keep it same..
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15325#discussion_r1469371280
More information about the client-libs-dev
mailing list