RFR: 8323670: A few client tests intermittently throw ConcurrentModificationException [v2]

Tejesh R tr at openjdk.org
Tue Jan 30 13:55:44 UTC 2024


On Mon, 29 Jan 2024 19:50:51 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Tejesh R has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - Revert fix 8307091 + Synchronised filecache
>>  - Merge branch 'master' of https://git.openjdk.java.net/jdk into branch_8323670
>>  - Fix
>
> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicDirectoryModel.java line 344:
> 
>> 342:             // execute the whole block on the COM thread
>> 343:             runnable = ShellFolder.invoke(new Callable<DoChangeContents>() {
>> 344:                 public DoChangeContents call() {
> 
> To reduce indentation level, you may convert the anonymous class to a lambda expression or even to a method in `FilesLoader` in which case you could use method reference.

Since I have updated the indentations now, I'll leave it that way.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17462#discussion_r1471256172


More information about the client-libs-dev mailing list