RFR: 8320342: Use PassFailJFrame for TruncatedPopupMenuTest.java

[Alexey Ivanov]

On Tue, 30 Jan 2024 21:49:12 GMT, Rajat Mahajan <rmahajan at openjdk.org> wrote:

> Modified the test to use PassFailJFrame and open sourced it.
> The test shows two windows, one for instructions and the other to perform testing on.
> Tested locally and it works fine.

Looks good, except for minor nits.

test/jdk/java/awt/PopupMenu/TruncatedPopupMenuTest.java line 31:

> 29: import java.awt.event.MouseEvent;
> 30: 
> 31: /* @test

Suggestion:

/*
 * @test

Keep the first line of the comment empty; it's empty usually.

test/jdk/java/awt/PopupMenu/TruncatedPopupMenuTest.java line 64:

> 62:                       .awaitAndCheck();
> 63: 
> 64:     }

Suggestion:

                      .awaitAndCheck();
    }

I suggest removing this blank line in the end of the method.

-------------

Marked as reviewed by aivanov (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17641#pullrequestreview-1854195222
PR Review Comment: https://git.openjdk.org/jdk/pull/17641#discussion_r1473083371
PR Review Comment: https://git.openjdk.org/jdk/pull/17641#discussion_r1473081463