RFR: 6507038: Memory Leak in JTree / BasicTreeUI [v6]
Alexey Ivanov
aivanov at openjdk.org
Wed Jan 31 17:30:06 UTC 2024
On Wed, 31 Jan 2024 17:13:55 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Optimise test
>
> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicTreeUI.java line 3284:
>
>> 3282: if(tree != null) {
>> 3283: rendererPane.removeAll();
>> 3284: // Only ever removed when UI changes, this is OK!
>
> The comment no longer applies—you remove all the components from `rendererPane` on the line above.
This is the only important thing that prevents me from approving this PR. The comment is misleading now.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17458#discussion_r1473193899
More information about the client-libs-dev
mailing list