RFR: 8155030: The Menu Mnemonics are always displayed for GTK LAF [v11]

Abhishek Kumar abhiscxk at openjdk.org
Wed Jul 3 04:14:46 UTC 2024


On Fri, 28 Jun 2024 19:59:15 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove AquaMnemonicHandler class and unused APIs from WinDowsLookAndFeel, copyright year update
>
> test/jdk/com/sun/java/swing/plaf/gtk/TestMenuMnemonicOnAltPress.java line 1:
> 
>> 1: /*
> 
> You extended the test to Aqua, so the test doesn't belong in `swing.plaf.gtk` any more.
> 
> I recommend moving it closer to the test you wrote for Windows: [`JMenuBar/TestMenuMnemonic.java`](https://github.com/openjdk/jdk/blob/master/test/jdk/javax/swing/JMenuBar/TestMenuMnemonic.java).
> 
> The new test could be `JMenuBar/TestMenuMnemonicLinuxAndMac.java`.
> 
> The old test could be renamed to `TestMenuMnemonicWindows.java`; or leave it unchanged.

Updated to `JMenuBar/TestMenuMnemonicLinuxAndMac.java`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18992#discussion_r1663456877


More information about the client-libs-dev mailing list