RFR: 8155030: The Menu Mnemonics are always displayed for GTK LAF [v11]

[Abhishek Kumar]

On Fri, 28 Jun 2024 19:11:21 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove AquaMnemonicHandler class and unused APIs from WinDowsLookAndFeel, copyright year update
>
> src/java.desktop/macosx/classes/com/apple/laf/AquaButtonUI.java line 493:
> 
>> 491:         final Graphics2D g2d = g instanceof Graphics2D ? (Graphics2D)g : null;
>> 492: 
>> 493:         final AbstractButton b = (AbstractButton)c;
> 
> Perhaps, it makes sense to remove `g2d` local variable — it's unused.

Updated.

> src/java.desktop/macosx/classes/com/apple/laf/AquaLabelUI.java line 32:
> 
>> 30: import javax.swing.*;
>> 31: import javax.swing.plaf.*;
>> 32: import javax.swing.plaf.basic.*;
> 
> Could you expand all the wildcard imports?

Done.

> src/java.desktop/macosx/classes/com/apple/laf/AquaMenuPainter.java line 34:
> 
>> 32: import javax.swing.border.Border;
>> 33: import javax.swing.plaf.basic.BasicHTML;
>> 34: import javax.swing.text.View;
> 
> Could you expand all the wildcard imports?

Updated.

> src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/GTKLookAndFeel.java line 53:
> 
>> 51: import sun.swing.SwingUtilities2;
>> 52: import sun.swing.MnemonicHandler;
>> 53: import sun.swing.AltProcessor;
> 
> Could you expand all the wildcard imports?
> 
> Allow your IDE sort the imports; `AltProcessor` should go before `DefaultLayoutStyle` and `MnemonicHandler` should go before `SwingAccessor`.

Updated the wild imports.
My IDE doesn't indicate if imports are sorted or not or if any imports are unused. 
Does it require to do some settings in IDE?

> src/java.desktop/windows/classes/com/sun/java/swing/plaf/windows/WindowsGraphicsUtils.java line 31:
> 
>> 29: import sun.swing.MnemonicHandler;
>> 30: 
>> 31: import java.awt.*;
> 
> Could you expand all the wildcard imports?

Updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18992#discussion_r1663459613
PR Review Comment: https://git.openjdk.org/jdk/pull/18992#discussion_r1663459662
PR Review Comment: https://git.openjdk.org/jdk/pull/18992#discussion_r1663459498
PR Review Comment: https://git.openjdk.org/jdk/pull/18992#discussion_r1663459425
PR Review Comment: https://git.openjdk.org/jdk/pull/18992#discussion_r1663458483