RFR: 8333403: Write a test to check various components events are triggered properly [v4]
Ravi Gupta
rgupta at openjdk.org
Thu Jul 4 10:25:39 UTC 2024
On Tue, 2 Jul 2024 22:12:45 GMT, Alisen Chung <achung at openjdk.org> wrote:
>> Ravi Gupta has updated the pull request incrementally with one additional commit since the last revision:
>>
>> 8333403: Review comments fixed
>
> test/jdk/java/awt/event/ComponentEvent/ComponentEventTest.java line 171:
>
>> 169: EventQueue.invokeAndWait(() -> {
>> 170: frame.dispose();
>> 171: frame.setVisible(true);
>
> I'm not really understanding this part. Why do you dispose the frame then setVisible here?
Thanks to providing the review comments here I want to revalidate the screen resources by dispose and setVisible the frame before the frame ICONIFIED test.
These lines are not required , After removing these lines test also works fine.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19521#discussion_r1665496123
More information about the client-libs-dev
mailing list