RFR: 8155030: The Menu Mnemonics are always displayed for GTK LAF [v17]

Alexey Ivanov aivanov at openjdk.org
Mon Jul 8 15:22:39 UTC 2024


On Mon, 8 Jul 2024 09:39:11 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> In GTK LAF, the menu mnemonics are always displayed which is different from the native behavior. In native application **(tested with gedit for normal buttons and tested with libreoffice for menu**), the menu mnemonics toggle on press of `ALT` key. Menu mnemonics are hidden initially and then toggles between show/hide on `ALT` press. 
>> Proposed fix is to handle the `ALT` key press for GTK LAF and mimic the native behavior. Fix is similar to the `ALT` key processing in  Windows LAF. Automated test case is added to verify the fix and tested in Ubuntu and Oracle linux.
>> 
>> CI testing is green and link attached in JBS.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   wild import expand. SynthGraphicsUtils revert back

Changes requested by aivanov (Reviewer).

src/java.desktop/share/classes/sun/swing/MnemonicHandler.java line 2:

> 1: /*
> 2:  * Copyright (c) (c) 2011, 2024, Oracle and/or its affiliates. All rights reserved.

Suggestion:

 * Copyright (c) 2011, 2024, Oracle and/or its affiliates. All rights reserved.

Too many `(c)` now.

-------------

PR Review: https://git.openjdk.org/jdk/pull/18992#pullrequestreview-2163659222
PR Review Comment: https://git.openjdk.org/jdk/pull/18992#discussion_r1668838420


More information about the client-libs-dev mailing list