RFR: 8335231: [macos] Test java/awt/print/PrinterJob/Cancel/PrinterJobCancel.java failed on macOS because the case didn't get the expected PrintAbortException
Tejesh R
tr at openjdk.org
Tue Jul 9 15:57:41 UTC 2024
On Thu, 4 Jul 2024 10:34:24 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:
> When a printjob is cancelled midway, `PrinterAbortException `was not thrown in macos. because
> firstly,` cancelCheck` invokes` LWCToolkit.invokeLater` with null as parameter causing it to fail with NPE and
> secondly PrinterAbortException was consumed silently when `printLoop` throws any exception
> which is rectified to throw the PrinterAbortException when encountered..
Looks good to me. I've tested the fix in macos and it works as expected.
-------------
Marked as reviewed by tr (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/20027#pullrequestreview-2166770774
More information about the client-libs-dev
mailing list