RFR: 8334599: Improve code from JDK-8302671 [v2]

[Phil Race]

On Wed, 3 Jul 2024 13:34:38 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> In [JDK-8302671](https://bugs.openjdk.org/browse/JDK-8302671) I fixed a memmove decay bug by rewriting a sizeof on an array to an explicit size of 256, but this is a bit of a band aid fix. It's come to my attention that in C++, one can pass an array by reference, which causes sizeof to work correctly on an array and has the added bonus of enforcing an array of that size on the arguments passed to that method. I've reverted my change from 8302671 and instead explicitly made kstate an array reference so that sizeof works on the array as expected, and that the array size can be explicitly set in the array brackets
>> 
>> Verification: https://godbolt.org/z/Ezj76eWWY and GitHub Actions
>
> Julian Waters has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
> 
>  - Formatting sizeof awt_Component.cpp
>  - Formatting awt_Component.cpp
>  - Merge branch 'openjdk:master' into patch-10
>  - Update src/java.desktop/windows/native/libawt/windows/awt_Component.cpp
>    
>    Co-authored-by: Alexey Ivanov <alexey.ivanov at oracle.com>
>  - 8334599

I'd leave the memmove as it is unless someone can show a measurable benefit to changing to memcpy.

I do agree with the suggested formatting changes.

-------------

Marked as reviewed by prr (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19798#pullrequestreview-2167213082