RFR: 7188058: Background of TextComponents are not changing colors to the default disabled color when set to uneditable
Damon Nguyen
dnguyen at openjdk.org
Wed Jul 10 21:49:55 UTC 2024
On Wed, 3 Jul 2024 23:39:58 GMT, Alisen Chung <achung at openjdk.org> wrote:
>> src/java.desktop/share/classes/java/awt/TextComponent.java line 366:
>>
>>> 364: super.setBackground(c);
>>> 365: }
>>> 366:
>>
>> Does this need a method need a javadoc comment block like the `setBackground` method before it or like any of the methods in the class?
>
> since this method isn't a public or protected method (it's package-private, so it can't be accessed by users) there's no need for a javadoc comment
Right. OK I'll wait for you to move the test to the AWT directory then because I do agree, the components involved seem to be AWT rather than Swing ones.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19876#discussion_r1673090674
More information about the client-libs-dev
mailing list