RFR: 8155030: The Menu Mnemonics are always displayed for GTK LAF [v18]

Abhishek Kumar abhiscxk at openjdk.org
Thu Jul 11 05:08:03 UTC 2024


On Wed, 10 Jul 2024 23:35:59 GMT, Phil Race <prr at openjdk.org> wrote:

> This looks like it is much better than the first iteration and being able to unify some code is good. The change looks "big" but seems to be mostly because of refactoring. I suppose you tracked down all tests that need updating ? Meaning manual as well as automated.

Yeah, many files got changed due to code refactoring . Tests which failed in CI testing due to changes are updated and working fine now. Searched for the helper method reference in other tests (manual or automated) but seems there are no more tests that refer to old implementation.

CI link is posted in JBS.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18992#issuecomment-2222040544


More information about the client-libs-dev mailing list