RFR: 8216471: GTK LnF: Frame is clipped and does not show JTable,Tooltip and JTree demo in SwingSet2 demo [v4]

Prasanta Sadhukhan psadhukhan at openjdk.org
Fri Jul 12 09:35:55 UTC 2024


On Fri, 12 Jul 2024 09:34:48 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> The issue is due to the preferred width of the toggle button in GTK L&F for GTK3 only.
>> Comparing the preferred width of toggle button with GTK2 or other LAF, it is much higher in GTK3. The difference is due to the insets value in GTK3.
>> 
>> In SwingSet2 demo there are as many as 16 demos are added in toolbar and the preferred width of frame is set to 720px.
>> In GTK L&F (For GTK3), overall preferred width of toolbar is ~980 px which is more than frame width and that results in the clipping of last few demos.
>> In other L&F and GTK2, the preferred width of toolbar is less than frame width. Hence, there is no clipping.
>> 
>> The proposed solution is to increase the width and height of SwingSet2 demo frame.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   height offset decreased

Looks good to me..
Hope you have tested on windows and mac too..

-------------

Marked as reviewed by psadhukhan (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20052#pullrequestreview-2174301527


More information about the client-libs-dev mailing list