RFR: 8335231: [macos] Test java/awt/print/PrinterJob/Cancel/PrinterJobCancel.java failed on macOS because the case didn't get the expected PrintAbortException
Abhishek Kumar
abhiscxk at openjdk.org
Wed Jul 17 10:21:51 UTC 2024
On Thu, 4 Jul 2024 10:34:24 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:
> When a printjob is cancelled midway, `PrinterAbortException `was not thrown in macos. because
> firstly,` cancelCheck` invokes` LWCToolkit.invokeLater` with null as parameter causing it to fail with NPE and
> secondly PrinterAbortException was consumed silently when `printLoop` throws any exception
> which is rectified to throw the PrinterAbortException when encountered..
Is it required to change the copyright year for test as well ?
otherwise tested with the current changes and it looks good to me.
-------------
Marked as reviewed by abhiscxk (Committer).
PR Review: https://git.openjdk.org/jdk/pull/20027#pullrequestreview-2182506320
More information about the client-libs-dev
mailing list