RFR: 4265389: JSplitPane does not support ComponentOrientation [v3]
Prasanta Sadhukhan
psadhukhan at openjdk.org
Thu Jul 18 08:58:16 UTC 2024
On Wed, 17 Jul 2024 11:25:25 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:
>> JSplitPane's support of CompoentOrientation is not present so if orientation is RTL, it still renders left component on left and right component on right instead of other way around..
>> Fix to make it support RTL orientation
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>
> Typo
src/java.desktop/share/classes/javax/swing/JSplitPane.java line 358:
> 356: "or JSplitPane.VERTICAL_SPLIT");
> 357: continuousLayout = newContinuousLayout;
> 358: if (this.getComponentOrientation().equals(ComponentOrientation.LEFT_TO_RIGHT)) {
In the constructor, the orientation cannot be ascertained so the fix is moved to setEnabled
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20214#discussion_r1682470313
More information about the client-libs-dev
mailing list