RFR: 4265389: JSplitPane does not support ComponentOrientation [v5]

[Tejesh R]

On Thu, 18 Jul 2024 13:40:12 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> JSplitPane's support of CompoentOrientation is not present so if orientation is RTL, it still renders left component on left and right component on right instead of other way around..
>> Fix to make it support RTL orientation
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Override setComponentOrientation

src/java.desktop/share/classes/javax/swing/JSplitPane.java line 376:

> 374:         Component rightComponent = this.getRightComponent();
> 375:         if (this.getComponentOrientation().equals(ComponentOrientation.RIGHT_TO_LEFT)) {
> 376:             if (rightComponent != null) {

I hope `null` is redundant here, because it is handled inside `setRightComponent/setLeftComponent`. I don't see any difference with and without `null` check while testing in my local. Any particular reason for adding `null` check here?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20214#discussion_r1683969100