RFR: 4265389: JSplitPane does not support ComponentOrientation [v7]

[Prasanta Sadhukhan]

On Mon, 22 Jul 2024 09:33:00 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use isLeftToRight method instead of explicit check
>
> src/java.desktop/share/classes/javax/swing/JSplitPane.java line 375:
> 
>> 373:         Component leftComponent = this.getLeftComponent();
>> 374:         Component rightComponent = this.getRightComponent();
>> 375:         if (!this.getComponentOrientation().isLeftToRight()) {
> 
> Just a suggestion, may not require to check for the `!` now as LTR or UNKNOWN can be handled together when `isLeftToRight` returns **true**. It is slightly confusing to understand. 
> 
> Need a bit of code swapping between if-else block.

yes but harmless, I guess...dont think it will be called repeatedly to set orientation so no performance impact..

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20214#discussion_r1686266248