RFR: 8335131: Test "javax/swing/JColorChooser/Test6977726.java" failed on ubuntu x64 because "Preview" title is missing for GTK L&F [v3]
Abhishek Kumar
abhiscxk at openjdk.org
Wed Jul 24 04:38:35 UTC 2024
On Tue, 23 Jul 2024 11:38:24 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:
> The test summary says it tests `setPreviewPanel`...if it's not present in native, then the full test is not applicable for GTK..
Actually the PreviewPanel is added for all L&F in JDK implementation in BasicColorChooserUI ( see here [L147](https://github.com/kumarabhi006/jdk/blob/70f3e99016311a6520e6a7c0da4c7ff718364976/src/java.desktop/share/classes/javax/swing/plaf/basic/BasicColorChooserUI.java#L147) and [L365](https://github.com/kumarabhi006/jdk/blob/70f3e99016311a6520e6a7c0da4c7ff718364976/src/java.desktop/share/classes/javax/swing/plaf/basic/BasicColorChooserUI.java#L365) ).
So, `setPreviewPanel` should be ok for GTK as well.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20104#discussion_r1689107744
More information about the client-libs-dev
mailing list