RFR: 8335131: Test "javax/swing/JColorChooser/Test6977726.java" failed on ubuntu x64 because "Preview" title is missing for GTK L&F [v4]

Abhishek Kumar abhiscxk at openjdk.org
Wed Jul 24 06:28:03 UTC 2024


> This test was modified under [JDK-8328403](https://bugs.openjdk.org/browse/JDK-8328403) bug to remove the applet usage. Test modification includes the instruction change as well which says that `Check that there is a panel with "Text Preview Panel" text and with title "Preview" in the JColorChooser`. Applet test didn't say explicitly about the panel title.
> 
> When the test is run with `GTKLookAndFeel` option, `Preview` title is missing due to the `showPreviewPanelText` property defined for `GTKLookAndFeel` is set to **FALSE**. `showPreviewPanelText` property is not defined for other L&Fs and that leads to fallback to the default value of **TRUE** for the property while lookup.
> 
> Proposed fix is to change the default value of `showPreviewPanelText` property to **TRUE** for GTK L&F.

Abhishek Kumar has updated the pull request incrementally with two additional commits since the last revision:

 - typo
 - comment added for the GTK property

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/20104/files
  - new: https://git.openjdk.org/jdk/pull/20104/files/48708d4e..a4a32a36

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=20104&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=20104&range=02-03

  Stats: 6 lines in 1 file changed: 6 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/20104.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20104/head:pull/20104

PR: https://git.openjdk.org/jdk/pull/20104


More information about the client-libs-dev mailing list