RFR: 8336879: Always true condition 'img != null' in GTKPainter.paintPopupMenuBackground [v2]

[Abhishek Kumar]

On Thu, 25 Jul 2024 04:01:03 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> In GTKPainter.paintPopupMenuBackground method, `img != null` condition will always be true, because it's only checked after `img.getRGB` method is called and that means img can't be `null`.  So, the null check condition is removed. CI testing is ok.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review comment fix

> also to be noted why only in this method, finishPainting returned image is being used, other several places, it does not check the returned image at all..

Yes but I am unsure about this and it seems to me that it is to paint pop up menu border when there is no text or icon for menu items to distinguish there are menu items present.

![Menu_No_Border](https://github.com/user-attachments/assets/a651daf7-4b30-494a-b76c-349586288766)
![Menu_With_Border](https://github.com/user-attachments/assets/61cd8e33-5147-44c0-a04e-4d5402c04999)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20308#issuecomment-2249402666