RFR: 8335967: "text-decoration: none" does not work with "A" HTML tags [v2]

Abhishek Kumar abhiscxk at openjdk.org
Thu Jul 25 09:36:32 UTC 2024


On Thu, 25 Jul 2024 09:18:50 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> After I integrated [JDK-8326734](https://bugs.openjdk.org/browse/JDK-8326734), there's no way to remove text decoration from an HTML element. The most common HTML element is `<a>` which is usually rendered _underlined_. You could add an inline style or apply a rule with `text-decoration: none` to remove underline.
>> 
>> This fix restores this functionality.
>> 
>> The test contains five cases. The first case ensures the `<a>` element is rendered with underline by default. The second and third cases verify that underline is removed if `text-decoration: none` is added to the `style` attribute or is applied by a style-sheet rule.
>> 
>> The fourth and fifth cases verify that underline is preserved the containing element, `<p>` in this case, has `text-decoration: underline`.
>> 
>> These five cases render the same way in browsers. However, the fourth and fifth cases render without underline in JDKs without JDK-8326734.
>
> Alexey Ivanov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Amend the bugid and summary in the test

Verified the test with the fix. It works as expected.

-------------

Marked as reviewed by abhiscxk (Committer).

PR Review: https://git.openjdk.org/jdk/pull/20313#pullrequestreview-2198806383


More information about the client-libs-dev mailing list