RFR: 8336879: Always true condition 'img != null' in GTKPainter.paintPopupMenuBackground [v2]

Abhishek Kumar abhiscxk at openjdk.org
Thu Jul 25 12:35:05 UTC 2024


On Thu, 25 Jul 2024 12:21:54 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comment fix
>
> Marked as reviewed by psadhukhan (Reviewer).

@prsadhuk Please re-review due to recent changes.

> src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/GTKPainter.java line 616:
> 
>> 614:                 int border = img.getRGB(0, h / 2);
>> 615:                 if (border == img.getRGB(w / 2, h / 2)) {
>> 616:                     // fix no menu borders in Adwaita theme
> 
> since it is needed for Yaru also, then I guess it's better to remove specific mention of Adwaita

Ok... updated.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20308#issuecomment-2250211577
PR Review Comment: https://git.openjdk.org/jdk/pull/20308#discussion_r1691363048


More information about the client-libs-dev mailing list