RFR: 8335267: [XWayland] move screencast tokens from .awt to .java folder

Phil Race prr at openjdk.org
Thu Jul 25 20:35:31 UTC 2024


On Thu, 25 Jul 2024 15:39:53 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> src/java.desktop/unix/classes/sun/awt/screencast/TokenStorage.java line 113:
>> 
>>> 111:         Path secondaryPath = Path.of(userHome, REL_NAME_SECONDARY);
>>> 112: 
>>> 113:         Path path = Files.isWritable(secondaryPath) && !Files.isWritable(primaryPath)
>> 
>> isWritable() returns false for both paths if it's the very first run with a particular home directory.
>
> Sure, then it chooses the primary path and creates the missing directories as expected.
> 
> The idea is to use the secondary path for compatibility reasons only if it exists and the primary path doesn't.

What I don't see here, which I think I expected to see, is that if only the secondary path exists, we copy what's there to the primary path, so that next time we go straight to the primary path.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20234#discussion_r1692080552


More information about the client-libs-dev mailing list