RFR: 8336879: Always true condition 'img != null' in GTKPainter.paintPopupMenuBackground [v3]

Tejesh R tr at openjdk.org
Fri Jul 26 06:22:32 UTC 2024


On Thu, 25 Jul 2024 12:35:05 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> In GTKPainter.paintPopupMenuBackground method, `img != null` condition will always be true, because it's only checked after `img.getRGB` method is called and that means img can't be `null`.  So, the null check condition is removed. CI testing is ok.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   minor spacing and comment fix

Looks good to me.

-------------

Marked as reviewed by tr (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20308#pullrequestreview-2201024568


More information about the client-libs-dev mailing list