RFR: 8336873: BasicSplitPaneDivider:oneTouchExpandableChanged() should mention that implementation depends on SplitPane.supportsOneTouchButtons property [v2]
Phil Race
prr at openjdk.org
Sun Jul 28 23:16:31 UTC 2024
On Tue, 23 Jul 2024 08:18:07 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:
>> BasicSplitPaneDivider:oneTouchExpandableChanged() spec doesn't mention that it will create left/right button only if L&F supports SplitPane.supportsOneTouchButtons which is now added in javadoc..
>
> Prasanta Sadhukhan has updated the pull request incrementally with three additional commits since the last revision:
>
> - typo
> - copyright year
> - L&F typo
The only LAF I see that sets supportsOneTouchButtons is GTK and it sets it to false ..
so nothing anywhere sets it to true !
And in the code being updated "true" is passed as the default value to DefaultLookup.getBoolean
So this seems to imply that a Laf has to consciously opt-out of one touch .. which is surprising to me. i.e you have to know about this property in the first place to opt-out .. and I don't see where it is documented so how can anyone writing a LaF know about it ?
Is there not a central document about all of these ?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/20289#issuecomment-2254683399
More information about the client-libs-dev
mailing list