RFR: 8329756: [macos] "javax/swing/JTable/KeyBoardNavigation.java" fail because most combinations of navigational keys with the Ctrl key do not work

[Abhishek Kumar]

On Thu, 25 Jul 2024 14:04:32 GMT, Tejesh R <tr at openjdk.org> wrote:

> Mismatch in key combinations, I have taken native macos Numbers application as reference to verify. Have added `Ctrl-Shift Left/Right` action keys similar to `Ctrl-Shift UP/DOWN` which would be expected functionality. I've removed those test instructions which are not applicable/implemented/not working in Macos keyboard navigation.

src/java.desktop/macosx/classes/com/apple/laf/AquaKeyBindings.java line 393:

> 391:             "ctrl shift DOWN", "selectLastRowExtendSelection",
> 392:             "ctrl shift RIGHT", "selectLastColumnExtendSelection",
> 393:             "ctrl shift LEFT", "selectFirstColumnExtendSelection"

any specific reason `ctrl shift left / right` is not there for Windows and Linux ?

test/jdk/javax/swing/JTable/KeyBoardNavigation.java line 276:

> 274:                                    scroll up/down one JViewport view;
> 275:                                    first visible cell in current column gets focus
> 276:                 fn - Allows editing in a cell containing information without

For consistency, use either FN or fn.

For the instruction mentioned at L273, when `FN+Down Arrow key` is pressed, viewport gets scroll down but I can see the cell selected is not the first visible cell in stead it is the first cell of last visible row.

Does this needs some rephrasing too?

And you may use
`FN + Up/Down Arrow` in stead of "FN+Up Arrow/FN+Down Arrow" since FN is common key.

test/jdk/javax/swing/JTable/KeyBoardNavigation.java line 284:

> 282:                 Shift-Left/Right Arrow - Extend selection left/right one column
> 283:                 Ctrl-Shift Up/Down Arrow -  Extend selection to top/bottom of row
> 284:                 Ctrl-Shift Left/Right Arrow -  Extend selection to first/last of column

Although the key combinations worked, I suggest to do some re-phrasing:

1. Shift-Up/Down Arrow - Extend selection to one cell up/down for current selected cell in the column
2. Shift-Left/Right Arrow - Extend selection to one cell left/right for current selected cell in the row
3. Ctrl-Shift Up/Down Arrow - Extend selection to top/bottom row for current selected cell in the column
4. Ctrl-Shift Left/Right Arrow - Extend selection to to first/last column for current selected cell in the row

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20331#discussion_r1694800929
PR Review Comment: https://git.openjdk.org/jdk/pull/20331#discussion_r1694643291
PR Review Comment: https://git.openjdk.org/jdk/pull/20331#discussion_r1694643486