RFR: 8337237: Use FFM instead of Unsafe for Java 2D RenderBuffer class [v3]
Phil Race
prr at openjdk.org
Mon Jul 29 17:09:49 UTC 2024
> Migrate from using Unsafe to FFM's MemorySegment API for allocating and setting native memory.
> This code is used by Metal, OpenGL and D3D, so I manually tested SwingSet2 and J2Demo as well as running all the usual tests.
> I also did some micro-benchmarking on the performance of Unsafe vs MemorySegment.
> The performance of either is more than sufficient for us .. ie they could be 10x slower and we wouldn't even notice.
> But they are in the same ballpark, and if one or the other is clearly faster it is the new FFM code.
Phil Race has updated the pull request incrementally with one additional commit since the last revision:
8337237
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/20339/files
- new: https://git.openjdk.org/jdk/pull/20339/files/5153f09e..d814521a
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=20339&range=02
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=20339&range=01-02
Stats: 6 lines in 1 file changed: 0 ins; 0 del; 6 mod
Patch: https://git.openjdk.org/jdk/pull/20339.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/20339/head:pull/20339
PR: https://git.openjdk.org/jdk/pull/20339
More information about the client-libs-dev
mailing list