RFR: 8329756: [macos] "javax/swing/JTable/KeyBoardNavigation.java" fail because most combinations of navigational keys with the Ctrl key do not work [v2]

[Abhishek Kumar]

On Mon, 29 Jul 2024 09:10:32 GMT, Tejesh R <tr at openjdk.org> wrote:

>> test/jdk/javax/swing/JTable/KeyBoardNavigation.java line 284:
>> 
>>> 282:                 Shift-Left/Right Arrow - Extend selection left/right one column
>>> 283:                 Ctrl-Shift Up/Down Arrow -  Extend selection to top/bottom of row
>>> 284:                 Ctrl-Shift Left/Right Arrow -  Extend selection to first/last of column
>> 
>> Although the key combinations worked, I suggest to do some re-phrasing:
>> 
>> 1. Shift-Up/Down Arrow - Extend selection to one cell up/down for current selected cell in the column
>> 2. Shift-Left/Right Arrow - Extend selection to one cell left/right for current selected cell in the row
>> 3. Ctrl-Shift Up/Down Arrow - Extend selection to top/bottom row for current selected cell in the column
>> 4. Ctrl-Shift Left/Right Arrow - Extend selection to to first/last column for current selected cell in the row
>
> Its not the extension of one cell (Its actually the number of cells in that row/column) and also extend selection for selected cell would not be right phrase, I feel.

I mean the selection is extended relative to that particular cell. When `Shift + UP` arrow is pressed, the cell just above the current selected cell is selected in that column and vice-versa. Same applied to `Shift + Left/Right` arrow but in row order.

And with `CTRL + Shift + UP / DOWN / LEFT / RIGHT` key combination is pressed, it will select the entire items just `above / below / left / right` of current selected item in column or row order.

Current instruction says `Shift-Up/Down Arrow -  Extend selection up/down one row` , but selection is limited to one cell only not entire row.

So, I thought the change will convey the instructions in a better way.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20331#discussion_r1696305158