RFR: 8329756: [macos] "javax/swing/JTable/KeyBoardNavigation.java" fail because most combinations of navigational keys with the Ctrl key do not work [v2]

Abhishek Kumar abhiscxk at openjdk.org
Tue Jul 30 05:03:33 UTC 2024


On Mon, 29 Jul 2024 09:00:18 GMT, Tejesh R <tr at openjdk.org> wrote:

>> src/java.desktop/macosx/classes/com/apple/laf/AquaKeyBindings.java line 393:
>> 
>>> 391:             "ctrl shift DOWN", "selectLastRowExtendSelection",
>>> 392:             "ctrl shift RIGHT", "selectLastColumnExtendSelection",
>>> 393:             "ctrl shift LEFT", "selectFirstColumnExtendSelection"
>> 
>> any specific reason `ctrl shift left / right` is not there for Windows and Linux ?
>
> It is there for Windows and Linux too. Its according to the native, in windows it extends to one cell left/right. In Linux there is a miss-match between native `Libre` and swing, might have to change that. I have updated as per Macos native side, where I took `Numbers` as reference.

In the test you have mentioned only `ctrl shift up / down` arrow key combination but not the `ctrl shift left / right` for windows and linux.
So, is it missed in test instructions?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20331#discussion_r1696308778


More information about the client-libs-dev mailing list