RFR: 8337287: Update image in javax.swing.text.Document.insert

Alexey Ivanov aivanov at openjdk.org
Wed Jul 31 16:13:31 UTC 2024


On Mon, 29 Jul 2024 18:33:08 GMT, Phil Race <prr at openjdk.org> wrote:

>> This changeset updates the image in the documentation for the `Document.insert` method. The image in `Document.remove` was updated by [JDK-4622866](https://bugs.openjdk.org/browse/JDK-4622866) in PR #15701.
>> 
>> Now the illustration of inserting looks similar to removing. The new image is in SVG format.
>> 
>> For reference:
>> 
>> - [`Document.insert` in JDK 22](https://docs.oracle.com/en/java/javase/22/docs/api/java.desktop/javax/swing/text/Document.html#insertString(int,java.lang.String,javax.swing.text.AttributeSet));
>> - [Updated docs for JDK 24](https://cr.openjdk.org/~aivanov/8337287/api/java.desktop/javax/swing/text/Document.html#insertString(int,java.lang.String,javax.swing.text.AttributeSet)).
>> 
>> As in the case with `remove`, I marked up to classes and members with {@code}.
>
> Marked as reviewed by prr (Reviewer).

@prrace Does it make sense to add a sentence which describes the image? I added one for `remove` to explain all the `Position`s in the removed area are collapsed.

Inserting a string is more straightforward: all the `Position`s at and after the insertion point are moved by the length of the inserted string.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20376#issuecomment-2260882097


More information about the client-libs-dev mailing list