RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v9]

Prasanta Sadhukhan psadhukhan at openjdk.org
Mon Jun 3 06:28:07 UTC 2024


On Fri, 31 May 2024 18:57:03 GMT, Alexander Scherbatiy <alexsch at openjdk.org> wrote:

>> If it's only about adding tray-1 to tray-11 in the above list and not about whole lot of changes in other areas, so that supported list contains those "tray-N" values, I guess we should add them..
>> I guess isSupportedAttributedValues(tray-N) will not return false in that case..
>
> Suppose `getSupportedAttributeValues(OutputBin.class, null, null)` returns [`top`, `face-down`] output bins.
> `isSupportedAttributedValues(...)` returns `true` for `OutputBin.TOP` and `OutputBin.FACE_DOWN` constants and `false` for `OutputBin.TRAY_1` if it was added in current implementation.
> 
> To make a one to one correspondence between `OutputBin.TOP` and `OutputBin.TRAY_1` constants it needs to add some logic and may be even make them equal in terms of `OutputBin` class which extends `EnumSyntax` class. 
> It is not clear should such logic be provided in the current release or it is better to provide its proper implementation in the next release if necessary.

ok

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16166#discussion_r1623839809


More information about the client-libs-dev mailing list