RFR: 8160755: bug6492108.java test fails with exception Image comparison failed at (0, 0) for image 4 in GTK L&F [v3]
Alexey Ivanov
aivanov at openjdk.org
Tue Jun 4 13:48:18 UTC 2024
On Mon, 3 Jun 2024 05:48:18 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:
>> Previous formatting was less confusing and aligned with Java Coding Style Guidelines.
>>
>> The parameters to the method are aligned to the opening parenthesis; the `throws` clause is not part of the parameters and it's placed on another line according to rules of wrapping lines (it should've used double-indentation of 8 spaces rather than 4 spaces to indicate a continuation line).
>
> Reverted back to previous formatting with double-indentation. Hopefully this should be ok now.
This formatting looks good to me.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19381#discussion_r1626008412
More information about the client-libs-dev
mailing list