RFR: 8315655: [macos] Right click and dragging over a component with a popup menu will open the popup [v4]

Prasanta Sadhukhan psadhukhan at openjdk.org
Fri Jun 7 07:42:12 UTC 2024


On Fri, 7 Jun 2024 07:20:35 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> I believe only MouseEvents can be popup triggers. I checked in MouseEvent that there is a field for popup triggers and no such field in KeyEvent. 
>> 
>> The isPopupTrigger method here also previously checked button down masks already, so adding a check for the correct mouse events shouldn't be an issue even if there was a way to show a popup menu with a different event type.
>
> looks good..

Although there's one more issue it seems where in native, after popup is shown when right mouse button (or CTRL+left mouse button) is pressed, if you release the mouse the popup vanishes which I noticed in Notes, Mail but it does not happen in JDK and popup remains open...but it seems not related to this...did you notice?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19569#discussion_r1630781731


More information about the client-libs-dev mailing list