RFR: 8315655: [macos] Right click and dragging over a component with a popup menu will open the popup [v6]

[Damon Nguyen]

On Fri, 7 Jun 2024 21:19:41 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Issue is a mouse drag will trigger a popup in macos, but not in linux or windows.
>> The solution is to add a check for a mouse pressed event to show popup and prevent mouse entered events from triggering the popup
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   update test based on feedback

Tested with and without the fix. Automating it does relieve the need to give a detailed pass/fail condition. Small nit suggestion.

test/jdk/javax/swing/JPopupMenu/MouseDragPopupTest.java line 59:

> 57:             });
> 58:             robot.waitForIdle();
> 59:             robot.delay(1000);

Suggestion:

            robot.setAutoDelay(100);
            robot.setAutoWaitForIdle(true);

            SwingUtilities.invokeAndWait(() -> {
                createAndShowGUI();
            });
            robot.delay(1000);


I was able to remove all the individual `waitForIdle()` calls and replaced it with `setAutoWaitForIdle()`. Still seemed to work fine on macOS.

-------------

Marked as reviewed by dnguyen (Committer).

PR Review: https://git.openjdk.org/jdk/pull/19569#pullrequestreview-2105491407
PR Review Comment: https://git.openjdk.org/jdk/pull/19569#discussion_r1631772988