RFR: 5021949: JSplitPane setEnabled(false) shouldn't be partially functional

Abhishek Kumar abhiscxk at openjdk.org
Thu Jun 13 15:56:13 UTC 2024


On Thu, 13 Jun 2024 12:54:57 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> Issue is seen in that if we call setEnabled(false) over JSplitPane than it can't be dragged via its divider, But if SplitPane have one touch expandable true than user can click those buttons and change the divider position. 
> So, if splitpane is disabled, then both dragging in divider and one-touch-expandable click should be disabled.
> Fix is made to override setEnabled and disable one-touch-expandable buttons actions..

I guess the test can be modified to iterate for all installed LAFs.

test/jdk/javax/swing/JSplitPane/TestSplitPaneEnableTest.java line 55:

> 53:             Robot robot = new Robot();
> 54:             SwingUtilities.invokeAndWait(() -> {
> 55:                 frame = new JFrame();

Frame title can be added.

-------------

PR Review: https://git.openjdk.org/jdk/pull/19695#pullrequestreview-2116195742
PR Review Comment: https://git.openjdk.org/jdk/pull/19695#discussion_r1638450360


More information about the client-libs-dev mailing list